Repository navigation
fix: correct app-store-badge-border CSS variable typo in dark mode - #184
Merged
Merged
Conversation
Contributor
Author
|
Follow-up: light-mode --color-app-store-badge-border should be var(--color-black) not rgb(166 166 166). Filled badges use bg-black; gray ring visible. Track separately or fix in follow-up PR. |
deebov
approved these changes
Jun 1, 2026
deebov
left a comment
Contributor
There was a problem hiding this comment.
Hey @Ali-hagha, thanks for the PR! Great catch!
Contributor
Author
|
Thanks! @deebov What do you think about the value of --color-app-store-badge-border? Is rgb(166 166 166) intentional, or should it reference a token like the other component variables (e.g. var(--color-black))? I'm not entirly sure the gray color used here is intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--color-app-store-badg-borderto--color-app-store-badge-borderin the dark mode theme block (styles/theme.css, line 718)ring-app-store-badge-borderutility used by app store buttonsTesting
Screenshots
before:
after:
Related issues
N/A