Skip to content
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

Add support for animated tilesets (tmx files) - #2612

Open
pflat wants to merge 3 commits into
urho3d:masterfrom
pflat:Tiled_animated_tile_support
Open

pflat wants to merge 3 commits into
urho3d:masterfrom
pflat:Tiled_animated_tile_support

Conversation

@pflat

@pflat pflat commented Mar 29, 2020

Copy link
Copy Markdown
Contributor

These changes allow the use of animated tiles in tmx maps.
I tested it by updating the map of sample 36 to contain some animated tiles.
I don't know if the way I choose to implement this fits with the codebase (I tried to). If it does, I'll check AS and LUA bindings. I'm dabbling with those bindings, so I'll only commit to that code if this one is ok.

@eugeneko

Copy link
Copy Markdown
Contributor

Apparently it causes crashes in two samples.

@pflat

pflat commented Mar 29, 2020

Copy link
Copy Markdown
Contributor Author

I believe I got the problem solved. Waiting for the tests to complete.

@weitjong weitjong added the улучшение Улучшение существующих вещей label Apr 5, 2020
@weitjong

weitjong commented Apr 5, 2020

Copy link
Copy Markdown
Contributor

Although I have not tested it, I believe it is merge-ready. I would have merge it if the script API binding is also provided.

@pflat

pflat commented Apr 6, 2020

Copy link
Copy Markdown
Contributor Author

The bindings for TmxFile2D were incomplete, both in LUA and AS. I added bindings for some methods, but the ones still remaining left me uncertain of how to do it.
Also for AngelScript, some classes had incorrect binds for the method GetProperty (they were "pointing" to HasProperty). I took the change correct it.

@github-actions

github-actions Bot commented May 7, 2020

Copy link
Copy Markdown

Marking this stale since there has been no activity for 30 days.
It will be closed if there is no activity for another 15 days.

@github-actions github-actions Bot added the stale label May 7, 2020
@weitjong weitjong added backlog and removed stale labels May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backlog улучшение Улучшение существующих вещей

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants