Skip to content

fix(editor): fixed search and replace input border - #8930

Merged
sid-bruno merged 2 commits into
usebruno:mainfrom
sachin-thakur-bruno:fix/header-codemirror-search-border
Aug 11, 2026
Merged

fix(editor): fixed search and replace input border#8930
sid-bruno merged 2 commits into
usebruno:mainfrom
sachin-thakur-bruno:fix/header-codemirror-search-border

Conversation

@sachin-thakur-bruno

@sachin-thakur-bruno sachin-thakur-bruno commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

BRU-4253

Codemirror search and replace input borders are not visible in Request Header.

Problem

RequestHeaders/StyledWrapper.js applies border: solid 1px transparent to all input[type='text'], overriding the search bar's visible border.

Fix

change the selector from .bruno-search-bar input to .bruno-search-bar input[type='text'] which will increase the specificity of the code mirror search input border.

Screenshots

Before After
image image

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.
  • I've run the claude code review skill locally.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Style
    • Updated search field styling to apply only to text inputs.
    • Prevented unrelated input elements within the search area from inheriting search field styles.

@sachin-thakur-bruno sachin-thakur-bruno changed the title fix(editor)/fixed search and replace input border fix(editor): fixed search and replace input border Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The CodeMirror search wrapper now scopes base and focus styling to input[type='text'] elements.

Changes

Search input styling

Layer / File(s) Summary
Scope search input selectors
packages/bruno-app/src/components/CodeMirrorSearch/StyledWrapper.js		 Base and focus styles now target only text inputs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bijin-bruno

Poem

Text inputs take the stage,
Focus styles stay in their cage.
Search bars shine with scope precise,
Two selectors make it nice.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing the search and replace input border in the editor.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sid-bruno
sid-bruno merged commit 6924173 into usebruno:main Aug 11, 2026
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sid-bruno sid-bruno sid-bruno approved these changes
@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner
@bijin-bruno bijin-bruno Awaiting requested review from bijin-bruno bijin-bruno is a code owner
@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner
@naman-bruno naman-bruno Awaiting requested review from naman-bruno
@vijayh-bruno vijayh-bruno Awaiting requested review from vijayh-bruno
@utkarsh-bruno utkarsh-bruno Awaiting requested review from utkarsh-bruno
@sanish-bruno sanish-bruno Awaiting requested review from sanish-bruno
+1 more reviewer
@Gopi-bruno Gopi-bruno Gopi-bruno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sachin-thakur-bruno @sid-bruno @Gopi-bruno