Skip to content

fix: adding mock server to test - #9503

Open
utkarsh-bruno wants to merge 1 commit into
usebruno:mainfrom
utkarsh-bruno:fix/mock-tese
Open

fix: adding mock server to test#9503
utkarsh-bruno wants to merge 1 commit into
usebruno:mainfrom
utkarsh-bruno:fix/mock-tese

Conversation

@utkarsh-bruno

@utkarsh-bruno utkarsh-bruno commented Oct 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Mock Server end-to-end tests were left out of the suite CI actually runs. npm run test:e2e now includes the mock-server Playwright project, and the testing notes match that.

Problem

npm run test:e2e only ran the default and system-pac projects. CI uses that script, so the Mock Server suite never ran there. auth and ssl stay on their own jobs.

Fix

Add --project=mock-server to the test:e2e script. The default Playwright ignore is unchanged, so the suite is not collected twice when both default and mock-server are selected.

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.
  • I've run the claude code review skill locally.

Summary by CodeRabbit

  • Documentation
    • Updated the testing quick reference to include the mock-server project and clarify which end-to-end test scripts cover each project.
  • Tests
    • The main end-to-end test command now runs the default, system PAC, and mock-server Playwright projects. Authentication and SSL tests remain available through their dedicated commands.

@utkarsh-bruno
utkarsh-bruno requested a review from a team October 9, 2026 16:07
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: usebruno/bruno/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2159f2c2-9758-4c59-ae17-e370ba5d716d
📥 Commits

Reviewing files that changed from the base of the PR and between 43b7c0f and d50582b.

📒 Files selected for processing (2)
  • .claude/rules/testing.md
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The default test:e2e script now runs the mock-server Playwright project alongside default and system-pac. The testing reference documents this project list and clarifies that auth and ssl use separate scripts and CI jobs.

Changes

End-to-end project selection

Layer / File(s) Summary
Default end-to-end project selection
package.json, .claude/rules/testing.md		 The test:e2e script now includes mock-server. The testing reference lists it and distinguishes the separate auth and ssl scripts and CI jobs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d5058

The standard end-to-end command now includes the configured mock-server project, with no concrete issue identified that blocks merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the main change: adding the Mock Server project to the test command. It is concise and related to the pull request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Three projects join the test command
Mock-server takes its place in line
Auth and SSL keep their own scripts
The testing notes now match the run
Clear paths guide the next test pass

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner
@bijin-bruno bijin-bruno Awaiting requested review from bijin-bruno bijin-bruno is a code owner
@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner
@sid-bruno sid-bruno Awaiting requested review from sid-bruno sid-bruno is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@utkarsh-bruno