feat(components)!: refactor components and make them consistent - #4912
Merged
Merged
Conversation
ilyaliao
marked this pull request as draft
July 24, 2025 17:02
Member
Author
|
I found that this kind of definition can handle the types of See f1907ef |
ilyaliao
force-pushed
the
refactor/components
branch
from
July 27, 2025 11:32
f1907ef to
d685a59
Compare
… and slots support
…and slots support
… and slots support
ilyaliao
force-pushed
the
refactor/components
branch
from
July 27, 2025 16:00
d685a59 to
6305838
Compare
…ition and slot support
…tion and slot support
…finition and slot support
…on and slot support
…n and slot support
…on and slot support
…inition and slot support
ilyaliao
marked this pull request as ready for review
August 11, 2025 16:53
Member
Author
|
I've marked this as a |
antfu
approved these changes
Aug 12, 2025
OrbisK
approved these changes
Aug 12, 2025
This was referenced Sep 1, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #4911, I decided to systematically review every
@vueuse/componentscomponent for props-related issues.This PR refactors
@vueuse/componentsto improve type safety and DX.props,emits, andslots.composablereturn types forcomponentusage.@vueuse/coreto prevent bundlers from inlining sub-entries.componentexamples and docs.Props:
Emit:
Slot: