Skip to content

fix(useFocusTrap): update focus-trap range to ^7 || ^8 - #5270

Merged
antfu merged 1 commit into
vueuse:mainfrom
wbolster:focus-trap-8
Jan 31, 2026
Merged

fix(useFocusTrap): update focus-trap range to ^7 || ^8#5270
antfu merged 1 commit into
vueuse:mainfrom
wbolster:focus-trap-8

Conversation

@wbolster

@wbolster wbolster commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

this loosens the focus-trap range to allow upgrading. focus-trap recently had a major release, but without API changes affecting useFocusTrap(); see https://github.com/focus-trap/focus-trap/releases/tag/v8.0.0

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Jan 30, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jan 30, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jan 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5270

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5270

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5270

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5270

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5270

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5270

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5270

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5270

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5270

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5270

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5270

commit: 4a794d9

@codecov

codecov Bot commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.35%. Comparing base (f503bde) to head (4a794d9).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5270   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files         343      343           
  Lines        6641     6641           
  Branches     2030     2030           
=======================================
  Hits         4274     4274           
  Misses       1965     1965           
  Partials      402      402

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antfu
antfu added this pull request to the merge queue Jan 31, 2026
Merged via the queue into vueuse:main with commit e279310 Jan 31, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes
@OrbisK OrbisK OrbisK approved these changes
@9romise 9romise 9romise approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wbolster @antfu @OrbisK @9romise