Update Egypt holidays#2742
Merged
Merged
Conversation
Contributor
Summary by CodeRabbit
WalkthroughThis update refactors the Egypt holiday logic to use observed and static holiday bases, introduces custom Islamic and static holiday classes, expands and revises holiday rules, updates localizations for Arabic, English, and adds French, and significantly enhances and restructures the Egypt holiday test suite. Changes
Estimated code review effort4 (~90 minutes) Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2742 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 271 271
Lines 16160 16199 +39
Branches 2182 2190 +8
=========================================
+ Hits 16160 16199 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
Merged
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Update Egypt holidays:
frlocaleType of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.