Update Egypt holidays: add Eid al-Fitr 2026 exact date#3474
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughExtended Egypt's confirmed Eid al‑Fitr range to include 2026, updated tests to assert 2026 Eid dates (standard and government non-observed), and added Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/countries/test_egypt.py`:
- Around line 203-205: The test currently lists explicit private/public dates
including "2026-03-20" and "2026-03-21" for Eid al-Fitr; extend the same test
method in tests/countries/test_egypt.py to also assert the corresponding 2026
government endpoints by adding the government endpoint entries for 2026 (the
same two dates) alongside the existing checks in that method so
government-specific assertions are pinned for 2026 as well.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 58854095-8e95-4404-b6c4-b4b90b279bde
📒 Files selected for processing (3)
CONTRIBUTORSholidays/countries/egypt.pytests/countries/test_egypt.py
Move source Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: Aziza Mohammed <114890850+aziamimoh@users.noreply.github.com>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
tests/countries/test_egypt.py (1)
203-204:⚠️ Potential issue | 🟡 MinorAdd missing 2026 government sector Eid al-Fitr dates to the test.
The test adds public sector dates for 2026 (03-20, 03-21) but the government sector dates are missing. Based on the pattern from prior years, government sector should be 2026-03-19 to 2026-03-22 (the day before through 2 days after the public holiday dates).
Update the explicit dates list in
assertGovernmentIslamicNoEstimatedHolidayName(lines 215–231) to include these 2026 government sector dates.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/countries/test_egypt.py` around lines 203 - 204, The government-sector Eid al-Fitr dates are missing for 2026 in the explicit dates list passed to assertGovernmentIslamicNoEstimatedHolidayName; update that list (the explicit dates argument in assertGovernmentIslamicNoEstimatedHolidayName) to include "2026-03-19" and "2026-03-22" in addition to the existing "2026-03-20" and "2026-03-21" so the government range covers the day before through two days after the public-sector holiday.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@tests/countries/test_egypt.py`:
- Around line 203-204: The government-sector Eid al-Fitr dates are missing for
2026 in the explicit dates list passed to
assertGovernmentIslamicNoEstimatedHolidayName; update that list (the explicit
dates argument in assertGovernmentIslamicNoEstimatedHolidayName) to include
"2026-03-19" and "2026-03-22" in addition to the existing "2026-03-20" and
"2026-03-21" so the government range covers the day before through two days
after the public-sector holiday.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: e71a768c-6ad0-44ee-8527-5b57b362479e
📒 Files selected for processing (1)
tests/countries/test_egypt.py
|
I added another reference, moved them to egypt.py, and added the government endpoints. |
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3474 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 313 313
Lines 18666 18666
Branches 2383 2383
=========================================
Hits 18666 18666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkid15r
left a comment
There was a problem hiding this comment.
@aziamimoh thanks for adding that 👍
Proposed change
Added Eid al-Fitr date for Egypt for 2026.
Date confirmed as March 20, 2026
Added corresponding test to ensure test coverage
Source: https://sis.gov.eg/en/media-center/news/dar-al-ifta-announces-friday-as-the-first-day-of-eidul-fitr/
Type of change
holidaysfunctionality in general)Checklist
make checklocally; all checks and tests passed.