Update United States holidays: add Good Friday, Christmas Eve, New Year's Eve to `UNOFFICIAL` category by PPsyrius · Pull Request #3324 · vacanza/holidays

PPsyrius · 2026-03-12T06:01:34Z

Proposed change

Add "Good Friday", "Christmas Eve", "New Year's Eve" to the United States UNOFFICIAL category holidays list.
Refactor for United States holidays test cases and their dependencies/territories.

Resolves #3323 .

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2026-03-12T06:01:52Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7186e6a4-cd93-433b-8ae6-cbc5ef0fdc5f

📥 Commits

Reviewing files that changed from the base of the PR and between 5d6ec27 and 6ca4f76.

📒 Files selected for processing (6)

holidays/countries/united_states.py
holidays/locale/en_US/LC_MESSAGES/US.po
holidays/locale/th/LC_MESSAGES/US.po
snapshots/countries/US_MA.json
tests/countries/test_puerto_rico.py
tests/countries/test_united_states.py

Summary by CodeRabbit

New Features
- Good Friday, Easter Sunday, Christmas Eve, and New Year's Eve added across US calendars and territories.
- Many dates now show combined observance labels and half-day closing notes.
- Holiday coverage extended through 2050 for states and territories.
Localization
- Added Easter Sunday to translation catalogs; new Thai translation included.

Walkthrough

Adds unofficial Easter-related and year‑end observances (Good Friday, Easter Sunday, Christmas Eve, New Year's Eve) to UnitedStates and injects corresponding date mappings and composite labels into many snapshot JSON locale files through 2050; also updates PO metadata and adds an Easter Sunday translation.

Changes

Cohort / File(s)	Summary
US source `holidays/countries/united_states.py`	Inserted unofficial holiday additions into `_populate_unofficial_holidays`: Good Friday, Easter Sunday, Christmas Eve, New Year's Eve (gated by year check and inline comments).
US state snapshots `snapshots/countries/US_*.json`, `snapshots/countries/US_AK.json`, `snapshots/countries/US_AL.json`, `snapshots/countries/US_AR.json`, `snapshots/countries/US_AS.json`, `snapshots/countries/US_AZ.json`, `snapshots/countries/US_CA.json`, `snapshots/countries/US_CO.json`	Bulk data insertions for Good Friday, Easter Sunday, Christmas Eve, New Year's Eve across many years; many entries converted to composite labels (e.g., "Christmas Day (observed); Christmas Eve", "New Year's Day (observed); New Year's Eve") and half‑day variants.
US territory / common snapshots `snapshots/countries/AS_COMMON.json`, `snapshots/countries/GU_COMMON.json`, `snapshots/countries/MP_COMMON.json`, `snapshots/countries/PR_COMMON.json`, `snapshots/countries/UM_COMMON.json`	Added Easter and year‑end holiday entries and composite labels across multi‑year ranges; expanded date maps with Good Friday, Easter Sunday, Christmas Eve, New Year's Eve.
Locale files `holidays/locale/en_US/LC_MESSAGES/US.po`, `holidays/locale/th/LC_MESSAGES/US.po`	Updated PO headers and added a new message entry/translation for "Easter Sunday".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Update United States holidays: add th l10n #2678: Modifies holidays/countries/united_states.py with Easter-related and localized holiday name changes.
Update the United States holidays: add Father's Day and Mother's Day for UNOFFICIAL category #2975: Alters _populate_unofficial_holidays in united_states.py to add unofficial entries (same function targeted).
Update US holidays: add federal holidays as GOVERNMENT category #2297: Changes US holiday population and snapshot generation; overlaps with added composite/observed label patterns.

Suggested reviewers

arkid15r

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title directly and specifically summarizes the main change: adding Good Friday, Christmas Eve, and New Year's Eve to UNOFFICIAL holidays for United States.
Description check	✅ Passed	Description clearly relates to the changeset, outlining the addition of three holidays to UNOFFICIAL category and refactoring of test cases.
Linked Issues check	✅ Passed	PR satisfies issue `#3323` requirements: adds Good Friday, Christmas Eve, and New Year's Eve to United States holidays, making them available when including Government and Unofficial categories.
Out of Scope Changes check	✅ Passed	All changes are scoped to adding the three requested holidays to UNOFFICIAL category, updating snapshots accordingly, and minor test/locale refactoring. No unrelated changes detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-03-12T06:11:40Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (27f4956) to head (6ca4f76).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          310       310           
  Lines        18580     18585    +5     
  Branches      2379      2380    +1     
=========================================
+ Hits         18580     18585    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Ryderjj89 · 2026-03-12T12:10:27Z

Does this include Easter Sunday as well?

PPsyrius · 2026-03-12T12:11:55Z

Does this include Easter Sunday as well?

No, but I can include that as well

…ar's Eve to `UNOFFICIAL` category

…gory

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

PPsyrius · 2026-03-14T11:17:29Z

I'm sorry for the forced git push, but that should fix our weird git merge issue earlier

sonarqubecloud · 2026-03-23T09:46:24Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KJhellico

LGTM! 👍

arkid15r

LGTM 👍

PPsyrius requested review from KJhellico and arkid15r as code owners March 12, 2026 06:01

github-actions Bot added snapshot test labels Mar 12, 2026

KJhellico reviewed Mar 13, 2026

View reviewed changes

Comment thread tests/countries/test_united_states.py

github-actions Bot added l10n ci labels Mar 14, 2026

PPsyrius and others added 3 commits March 14, 2026 18:15

Update United States holidays: add Good Friday, Christmas Eve, New Ye…

a92fe9c

…ar's Eve to `UNOFFICIAL` category

Update United States holidays: add Easter Sunday to UNOFFICIAL cate…

32c4a10

…gory

test_lee_jackson_day update

4b1b8d6

Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>

PPsyrius force-pushed the US_unofficial branch from ea8c930 to 4b1b8d6 Compare March 14, 2026 11:16

KJhellico reviewed Mar 14, 2026

View reviewed changes

Comment thread tests/countries/test_northern_mariana_islands.py

PPsyrius added 5 commits March 17, 2026 09:40

Merge branch 'dev' into US_unofficial

b59f942

Increment l10n version number

5d6ec27

Merge branch 'dev' into US_unofficial

033e1e3

Rerun make snapshot

3fd2174

remove duplicate federal holidays test

6ca4f76

PPsyrius requested a review from KJhellico March 23, 2026 09:44

KJhellico approved these changes Mar 23, 2026

View reviewed changes

arkid15r reviewed Mar 24, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Mar 24, 2026

Merged via the queue into vacanza:dev with commit bd01922 Mar 24, 2026
32 checks passed

PPsyrius deleted the US_unofficial branch March 24, 2026 03:16

KJhellico mentioned this pull request Apr 6, 2026

v0.94 #3508

Merged

coderabbitai Bot mentioned this pull request Apr 28, 2026

Update United States holidays: fix Georgia's State Holiday observance #3557

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update United States holidays: add Good Friday, Christmas Eve, New Year's Eve to `UNOFFICIAL` category#3324

Update United States holidays: add Good Friday, Christmas Eve, New Year's Eve to `UNOFFICIAL` category#3324
arkid15r merged 8 commits into
vacanza:devfrom
PPsyrius:US_unofficial

PPsyrius commented Mar 12, 2026

Uh oh!

coderabbitai Bot commented Mar 12, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented Mar 12, 2026 •

edited

Loading

Uh oh!

Ryderjj89 commented Mar 12, 2026

Uh oh!

PPsyrius commented Mar 12, 2026

Uh oh!

Uh oh!

PPsyrius commented Mar 14, 2026

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 23, 2026

Uh oh!

KJhellico left a comment

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

PPsyrius commented Mar 12, 2026

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai Bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Ryderjj89 commented Mar 12, 2026

Uh oh!

PPsyrius commented Mar 12, 2026

Uh oh!

Uh oh!

PPsyrius commented Mar 14, 2026

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 23, 2026

Quality Gate passed

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Mar 12, 2026 •

edited

Loading

codecov Bot commented Mar 12, 2026 •

edited

Loading