Skip to content

Update United States holidays: fix Georgia's State Holiday observance#3557

Merged
arkid15r merged 1 commit into
vacanza:devfrom
PPsyrius:us_ga
Apr 28, 2026
Merged

Update United States holidays: fix Georgia's State Holiday observance#3557
arkid15r merged 1 commit into
vacanza:devfrom
PPsyrius:us_ga

Conversation

@PPsyrius

@PPsyrius PPsyrius commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Proposed change

From https://en.wikipedia.org/wiki/Confederate_Memorial_Day#Statutory_holidays

Beginning in 2020, state offices in Georgia now observe Confederate Memorial Day on Good Friday, though it is still referred to as "State Holiday."

Resolves #3555.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai

coderabbitai Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9107e224-f218-4d5c-8466-7a8921ac3bee

📥 Commits

Reviewing files that changed from the base of the PR and between 0f93cb1 and 64c652d.

📒 Files selected for processing (3)
  • holidays/countries/united_states.py
  • snapshots/countries/US_GA.json
  • tests/countries/test_united_states.py

Summary by CodeRabbit

  • Bug Fixes

    • Corrected Georgia State Holiday observance to align with Good Friday dates starting from 2020.

  • Documentation

    • Enhanced Georgia holiday references with official state source links for holiday schedules.

Walkthrough

Georgia's State Holiday logic is updated to align with Good Friday starting in 2020, replacing previously fixed dates. Supporting snapshots and test expectations are revised to match this behavioral change.

Changes

Cohort / File(s) Summary
Logic Update
holidays/countries/united_states.py		 Modified Georgia State Holiday to use Good Friday via _add_good_friday() starting 2020, replacing fixed April 10 date. Added documentation and source links to official Georgia holiday schedule.
Snapshot Data
snapshots/countries/US_GA.json		 Updated holiday labels for 2021–2050 to merge State Holiday with Good Friday entries and remove redundant standalone State Holiday entries.
Test Expectations
tests/countries/test_united_states.py		 Adjusted test assertions for State Holiday dates to align with Good Friday starting 2020; updated localized output assertions for affected dates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

snapshot, test

Suggested reviewers

  • arkid15r
  • KJhellico
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: fixing Georgia's State Holiday observance to align with Good Friday instead of fixed dates.
Description check ✅ Passed The description clearly relates to the changeset, citing Wikipedia and referencing the specific issue (#3555) about Georgia's State Holiday observance.
Linked Issues check ✅ Passed The PR addresses issue #3555 by correcting Georgia's State Holiday to observe Good Friday starting in 2020, aligning with official state definitions to prevent automation errors.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing Georgia's State Holiday observance: logic updates, snapshot corrections, and test expectations align with the stated objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 28, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0f93cb1) to head (64c652d).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3557   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          313       313           
  Lines        18701     18701           
  Branches      2389      2389           
=========================================
  Hits         18701     18701

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico
KJhellico approved these changes Apr 28, 2026
View reviewed changes

@KJhellico KJhellico left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

arkid15r
arkid15r reviewed Apr 28, 2026
View reviewed changes

@arkid15r arkid15r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @PPsyrius 🚀

@arkid15r arkid15r added this pull request to the merge queue Apr 28, 2026
Merged via the queue into vacanza:dev with commit 9d862c4 Apr 28, 2026
32 checks passed
@PPsyrius PPsyrius deleted the us_ga branch April 29, 2026 03:49
@arkid15r arkid15r mentioned this pull request May 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

April 27 2026 Was Not A Public Holiday In Georgia, USA

3 participants

@PPsyrius @arkid15r @KJhellico