Update India holidays: add Kannada language support#3428
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds Kannada ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @arkid15r @KJhellico @PPsyrius 👋 I’ve submitted this PR adding Kannada ( Could you please take a moment to review it when you have time? I’d really appreciate your feedback and any suggestions for improvement. Thank you for your time and for maintaining this project! 🙂 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3428 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 310 310
Lines 18584 18584
Branches 2380 2380
=========================================
Hits 18584 18584 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Kartheekmurala <150778363+Kartheekmurala@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
holidays/locale/kn/LC_MESSAGES/IN.po (1)
139-479:⚠️ Potential issue | 🟠 MajorRemove orphan msgids that are not emitted by
India/Karnatakacode paths.This catalog includes many entries that don’t map to current
tr()strings inholidays/countries/india.py(per the provided snippets). Keep only msgids that exist in the generated template for India, otherwise these translations are dead and drift-prone.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@holidays/locale/kn/LC_MESSAGES/IN.po` around lines 139 - 479, The IN.po file contains many msgid entries not produced by the current India/Karnataka code paths; remove orphan translations that are not emitted by the tr() calls in holidays/countries/india.py so the catalog matches the generated template. Inspect the runtime/template of tr() strings in holidays/countries/india.py (and any Karnataka-specific branches), prune any msgid/msgstr pairs from IN.po that do not appear in that generated template, and keep only msgids currently produced by the India/Karnataka code paths to avoid stale translations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@holidays/locale/kn/LC_MESSAGES/IN.po`:
- Around line 449-451: Update the translator comment lines for the holiday
entries so they end with a period: change the comment before the "Kail Muhuruth"
msgid (currently "#. Kail Muhuruth") to "#. Kail Muhuruth." and likewise add a
trailing period to the comment before the "Buddha Purnima" msgid; ensure you
only modify the translator comment lines (those starting with "#.") adjacent to
the msgid "Kail Muhuruth" and the msgid "Buddha Purnima" to match repository
style.
---
Duplicate comments:
In `@holidays/locale/kn/LC_MESSAGES/IN.po`:
- Around line 139-479: The IN.po file contains many msgid entries not produced
by the current India/Karnataka code paths; remove orphan translations that are
not emitted by the tr() calls in holidays/countries/india.py so the catalog
matches the generated template. Inspect the runtime/template of tr() strings in
holidays/countries/india.py (and any Karnataka-specific branches), prune any
msgid/msgstr pairs from IN.po that do not appear in that generated template, and
keep only msgids currently produced by the India/Karnataka code paths to avoid
stale translations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: f5257c09-da4c-442e-85fa-c0ef6d308199
📒 Files selected for processing (1)
holidays/locale/kn/LC_MESSAGES/IN.po
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Kartheekmurala <150778363+Kartheekmurala@users.noreply.github.com>
|
@KJhellico Is there any further modifications required could you please specify ? |
|
Looks good.
|
The AI’s suggestions are mostly correct and align well with standard Kannada usage. Terms like ಸ್ಥಾಪನಾ ದಿನ and ಉದ್ಘಾಟನಾ ದಿನ are more accurate and official than the current translations. Simplifications such as ಮಕರ ಸಂಕ್ರಾಂತಿ and formatting fixes like ಈದ್-ಮಿಲಾದ್ improve clarity and consistency. Some suggestions need slight context awareness. For example, ಮೊಹರಂ is generally correct, but ಕಡೆ ದಿನ may apply when specifically referring to Ashura. Also, for state-related names, ನಾಗಾಲ್ಯಾಂಡ್ ರಾಜ್ಯ ಸ್ಥಾಪನಾ ದಿನ is more natural than the suggested version. Overall, the feedback is strong, with only minor refinements needed for context and phrasing. |
|
@KJhellico Sir I have applied the suggestions that have been given could you please verify once and tell me the changes needed thank you ! |
|
Ok, I see about Muharram. But why Nagaland state day name differs from most others? |
@KJhellico Thanks for the question! For Muharram, I used “ಮೊಹರಂ” since it’s the commonly used general name, while “ಕಡೆ ದಿನ” refers specifically to Ashura (the last day). I felt the shorter form is more appropriate for a general holiday label, but I can adjust if needed. For Nagaland, the original label is “Nagaland State Inauguration Day”, which differs slightly from most other states that use “Foundation Day”. While “ಉದ್ಘಾಟನಾ ದಿನ” would be a literal translation of “Inauguration”, in practice state holidays in India are generally referred to as “ಸ್ಥಾಪನಾ ದಿನ”. So I used “ನಾಗಾಲ್ಯಾಂಡ್ ರಾಜ್ಯ ಸ್ಥಾಪನಾ ದಿನ” to maintain consistency across all state holidays and align with common administrative usage. However, I’m happy to adjust this if you prefer keeping it closer to the original wording. |
|
So, it makes sense to keep Ashura and state holiday as they are, and use AI version for the rest. Right? |
Hii @KJhellico ! Just following up on this — please let me know if any further changes are needed. Thanks! |
|
|
@KJhellico @PPsyrius |
arkid15r
left a comment
There was a problem hiding this comment.
Thanks for teh contribution @Kartheekmurala 👍
|
@KJhellico @arkid15r @PPsyrius https://docs.google.com/document/d/1GJsWEhrJ-V7hL2EQjHb9iOpd7chY6RWw0xTKYXGHEW8/edit?usp=drivesdk |
Signed-off-by: Kartheekmurala <150778363+Kartheekmurala@users.noreply.github.com> Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Proposed change
Add Kannada (
kn) localization support for India holidays.Changes
holidays/locale/kn/LC_MESSAGES/IN.powith Kannada translations for India holidays.tests/countries/test_india.pywithtest_l10n_knto validate localized holiday names.README.mdto includeknin supported languages for India.holidays/countries/india.pyto includekninsupported_languages.Type of change
Checklist
make checklocally; all checks and tests passed.