Skip to content

Update .pre-commit-config.yaml: use SHA for versions#3516

Merged
arkid15r merged 2 commits into
vacanza:devfrom
arkid15r:ark/update-pre-commit-versions
Apr 9, 2026
Merged

Update .pre-commit-config.yaml: use SHA for versions#3516
arkid15r merged 2 commits into
vacanza:devfrom
arkid15r:ark/update-pre-commit-versions

Conversation

@arkid15r

@arkid15r arkid15r commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

Proposed change

Use SHA for pre-commit action versions

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai

coderabbitai Bot commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: be8fc81f-1510-461a-8294-77b26aefcf84

📥 Commits

Reviewing files that changed from the base of the PR and between 64c7e51 and 7375a33.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

Summary by CodeRabbit

  • Chores
    • Updated pre-commit hook pins to fixed revisions to ensure consistent and reproducible development checks.
    • Minor YAML formatting cleanup for one hook entry (no behavior changes).

Walkthrough

Updated commit-hash pins for multiple hooks in .pre-commit-config.yaml (pre-commit-hooks, pyupgrade, ruff-pre-commit, markdownlint-cli, isort, mirrors-mypy, pyproject-fmt); preserved existing hook IDs, args, file filters and other fields. One YAML indentation whitespace for pyupgrade was normalized.

Changes

Cohort / File(s) Summary
Pre-commit hook version pins
.pre-commit-config.yaml		 Replaced version-tag rev: vX.Y.Z entries with specific commit-hash rev values for eight hooks; inline comments retain prior version tags. One list-item indentation for pyupgrade adjusted (formatting only).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • KJhellico
  • PPsyrius
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating pre-commit config to use commit SHAs instead of version tags.
Description check ✅ Passed The description is relevant to the changeset, stating the intent to use SHA for pre-commit action versions and noting this is a quality improvement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3ff57eb) to head (7375a33).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3516   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          313       313           
  Lines        18666     18666           
  Branches      2383      2383           
=========================================
  Hits         18666     18666

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai[bot]
coderabbitai Bot reviewed Apr 8, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.pre-commit-config.yaml:
- Line 23: The YAML list item "-   id: pyupgrade" has extra spaces after the
hyphen; update the list item formatting to use a single space after the hyphen
(e.g., "- id: pyupgrade") so it conforms to YAML list-item spacing rules and
YAMLLint; ensure other list items in the same block (if any) follow the same "-
<key>: <value>" spacing pattern and validate the file after the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 933ce0a4-410c-4a57-ae49-b6b2b62ecfbd

📥 Commits

Reviewing files that changed from the base of the PR and between 3ff57eb and 64c7e51.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

Comment thread .pre-commit-config.yaml Outdated
@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arkid15r arkid15r marked this pull request as ready for review April 9, 2026 01:23
PPsyrius
PPsyrius approved these changes Apr 9, 2026
View reviewed changes

@PPsyrius PPsyrius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛠️

@arkid15r arkid15r added this pull request to the merge queue Apr 9, 2026
Merged via the queue into vacanza:dev with commit bb25f08 Apr 9, 2026
32 checks passed
@arkid15r arkid15r deleted the ark/update-pre-commit-versions branch April 9, 2026 03:27
@KJhellico KJhellico mentioned this pull request Apr 20, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 11, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@PPsyrius PPsyrius PPsyrius approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkid15r @PPsyrius