Update pre-commit config by KJhellico · Pull Request #3619 · vacanza/holidays

KJhellico · 2026-06-11T20:40:42Z

Proposed change

Update pre-commit config:

remove pyproject-fmt dependency pinning
remove mypy types-requests dependency (as requests package includes type annotations since version 2.34.0)

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've read and followed the contributing guidelines.
I've run make check locally; all checks and tests passed.

coderabbitai · 2026-06-11T20:40:56Z

Summary by CodeRabbit

Chores
- Adjusted pre-commit hook configuration for type checking and formatting.
- Removed an unnecessary type dependency and pinned specific type-related packages to fixed versions to stabilize checks.

Walkthrough

Updated .pre-commit-config.yaml: the mypy hook’s additional_dependencies now pins types-polib and types-python-dateutil and removes types-requests; the tox-dev/pyproject-fmt hook’s additional_dependencies override was removed, leaving only its id.

Changes

Pre-commit Hook Configuration Updates

Layer / File(s)	Summary
Pre-commit hook dependency updates `.pre-commit-config.yaml`	The `mypy` hook's `additional_dependencies` list is updated to remove `types-requests` and pin `types-polib` and `types-python-dateutil`. The `tox-dev/pyproject-fmt` hook's `additional_dependencies` override was removed, leaving only `id: pyproject-fmt`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

vacanza/holidays#3334: Modifies .pre-commit-config.yaml's pyproject-fmt hook configuration.
vacanza/holidays#3516: Updates .pre-commit-config.yaml hook configuration including mypy/pyproject-fmt dependency changes.
vacanza/holidays#2548: Adjusts mypy hook additional_dependencies (type stub changes).

Suggested labels

ci

Suggested reviewers

arkid15r
PPsyrius

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	Title is vague and generic, using non-descriptive language that doesn't clearly convey what aspects of the pre-commit config were modified.	Consider a more specific title like 'Remove types-requests and pyproject-fmt dependency pinning from pre-commit config' to clearly communicate the changes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	Description clearly outlines the changes: removing pyproject-fmt dependency pinning and mypy types-requests dependency, with reasoning about requests package type annotations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 1 file

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

codecov · 2026-06-11T20:43:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4232f38) to head (a464013).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #3619   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          315       315           
  Lines        18843     18843           
  Branches      2411      2411           
=========================================
  Hits         18843     18843

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sonarqubecloud · 2026-06-11T23:26:20Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.pre-commit-config.yaml:
- Around line 63-64: The pinned types stubs for polib and python-dateutil are
fine, but the requests typing decision is unsafe: either keep the types-requests
stub in the dev dependencies or raise the requests lower bound to >=2.34.0 so
inline annotations are present; update the dependency list accordingly by either
re-adding types-requests or changing the requests entry in your dev dependencies
(and remove the types-requests removal), and ensure the pinned stub entries
types-polib==1.2.0.20260518 and types-python-dateutil==2.9.0.20260518 remain
as-is.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3bbd5296-32b4-4494-8557-fecc9e06f2b8

📥 Commits

Reviewing files that changed from the base of the PR and between c8c9e3b and a464013.

📒 Files selected for processing (1)

.pre-commit-config.yaml

PPsyrius

LGTM 🛠️

Update pre-commit config

c8c9e3b

KJhellico requested review from PPsyrius and arkid15r as code owners June 11, 2026 20:40

cubic-dev-ai Bot reviewed Jun 11, 2026

View reviewed changes

Pin versions

a464013

coderabbitai Bot reviewed Jun 11, 2026

View reviewed changes

Comment thread .pre-commit-config.yaml

arkid15r approved these changes Jun 11, 2026

View reviewed changes

arkid15r enabled auto-merge June 11, 2026 23:30

PPsyrius approved these changes Jun 12, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Jun 12, 2026

Merged via the queue into vacanza:dev with commit 4d95867 Jun 12, 2026
33 checks passed

KJhellico deleted the upd-pre-commit branch June 12, 2026 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update pre-commit config#3619

Update pre-commit config#3619
arkid15r merged 2 commits into
vacanza:devfrom
KJhellico:upd-pre-commit

KJhellico commented Jun 11, 2026

Uh oh!

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

❌ Failed checks (1 inconclusive)

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

codecov Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Jun 11, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

PPsyrius left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

KJhellico commented Jun 11, 2026

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

❌ Failed checks (1 inconclusive)

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud Bot commented Jun 11, 2026

Quality Gate passed

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

codecov Bot commented Jun 11, 2026 •

edited

Loading