fix(windows_event_log): soft bookmark resume before future-events fallback - #26125
VedantMadane wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
75ad7da to
86ba467
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83e5c4001a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| error = %e | ||
| ); | ||
| EvtSubscribe( | ||
| match EvtSubscribe( |
There was a problem hiding this comment.
Apply the soft retry during initial subscription
When Vector starts with a persisted but stale bookmark and read_existing_events=false, the strict call in EventLogSubscription::new still falls directly through to a bookmark-less EvtSubscribeToFutureEvents (lines 281-299), silently skipping events between the checkpoint and startup. This new soft retry is reachable only after the running subscription reports an invalid position, so the same data-loss scenario remains on process restart; apply this retry to the initial-subscription path as well, preferably through shared logic.
Useful? React with 👍 / 👎.
47b7602 to
33c6131
Compare
33c6131 to
d9d2fb5
Compare
Summary
Fixes #26120.
When strict EvtSubscribeStartAfterBookmark|Strict fails (e.g. ERROR_NOT_FOUND), the previous path fell straight through to EvtSubscribeToFutureEvents when read_existing_events = false, dropping events between the last bookmark and now.
Insert a soft bookmark resume (StartAfterBookmark without Strict) before the last-resort future/oldest flags so recovery prefers continuity over a hard reset. Some re-delivery is possible; silent loss is not.
Test plan