Repository navigation
[rollout] fix: fix hf rollout and add single gpu test - #2371
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an AttributeError in the sharding manager and includes a new single-GPU test for the HF rollout. The PR also includes cleanups, removing the default_hdfs_dir parameter from various scripts and documentation. A more robust approach to initializing self.timing in BaseShardingManager is recommended.
eric-haibin-lin
enabled auto-merge (squash)
July 5, 2025 05:50
vermouth1992
approved these changes
Jul 5, 2025
SuperCB
pushed a commit
to SuperCB/verl
that referenced
this pull request
Jul 7, 2025
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jul 7, 2025
lkc233
pushed a commit
to lkc233/verl
that referenced
this pull request
Jul 10, 2025
oseyosey
pushed a commit
to oseyosey/verl
that referenced
this pull request
Jul 28, 2025
Juniper1021
pushed a commit
to Juniper1021/verl
that referenced
this pull request
Aug 7, 2025
whatadayG
pushed a commit
to whatadayG/verl
that referenced
this pull request
Sep 5, 2025
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
oseyosey
pushed a commit
to oseyosey/verl
that referenced
this pull request
Jan 20, 2026
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, the sharding manager would throw AttributeError that self.timing is not defined.
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
Added to ppo fsdp test suite.
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace.