Repository navigation
Revert "[single_controller] feat: support resource pool split method" - #4258
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts the resource pool split feature and replaces it with a new mechanism for resource allocation using replica_rank and replica_world_size in RayWorkerGroup. This simplifies RayResourcePool and moves the resource slicing logic into RayWorkerGroup, which seems like a good refactoring. However, I've found a critical issue in the new implementation within verl/single_controller/ray/base.py. The logic for assigning ranks to workers assumes a homogeneous cluster configuration (i.e., all nodes have the same number of processes), and it will fail in heterogeneous environments. I've provided a detailed comment and a suggested fix for this issue.
yyDing1
self-requested a review
November 24, 2025 06:52
wuxibin89
approved these changes
Nov 24, 2025
Di-viner
pushed a commit
to Di-viner/verl
that referenced
this pull request
Nov 30, 2025
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
zwluestc
pushed a commit
to zwluestc/verl
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4251