Conversation
- DataConsumer: make 'setBufferedAmountLowThreshold' trigger 'bufferedamountlow'
if the buffered amount data is less or same than the given threshold.
- SctpAssociation: Increase buffered amount data before sending it in
order to avoid inconsistencies if 'onSendSctpData' fires while 'usrsctp_senv'
is being executed. Be conservative.
Member
Author
|
We don't have full control on the real buffered data in usrsctp. With this changes we can subscribe to 'bufferedamountlow' event and set the buffered amount low threshold and we will be sure that:
|
ibc
reviewed
Nov 11, 2020
ibc
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataConsumer: make 'setBufferedAmountLowThreshold' trigger 'bufferedamountlow'
if the buffered amount data is less or same than the given threshold.
SctpAssociation: Increase buffered amount data before sending it in
order to avoid inconsistencies if 'onSendSctpData' fires while 'usrsctp_senv'
is being executed. Be conservative.