Skip to content

RtpStreamSend: Do not store too old RTP packets - #885

Merged
jmillan merged 3 commits into
v3from
issue_882
Jul 28, 2022
Merged

jmillan merged 3 commits into
v3from
issue_882

Conversation

@jmillan

@jmillan jmillan commented Jul 28, 2022

Copy link
Copy Markdown
Member

Fixes #882

@jmillan
jmillan requested review from ibc and nazar-pc July 28, 2022 11:14
Comment thread worker/src/RTC/RtpPacket.cpp
Comment thread worker/src/RTC/RtpStreamSend.cpp
Comment thread worker/src/RTC/RtpStreamSend.cpp
Comment thread worker/src/RTC/RtpStreamSend.cpp
@jmillan

jmillan commented Jul 28, 2022

Copy link
Copy Markdown
Member Author

Fuzzer would detect the crash right away, after the change it runs for long minutes without issues.

Comment thread worker/src/RTC/RtpStreamSend.cpp Outdated

@nazar-pc nazar-pc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, bug was tricky, glad that we have fuzzer

@jmillan

jmillan commented Jul 28, 2022

Copy link
Copy Markdown
Member Author

I'm merging and releasing a new version

@jmillan
jmillan merged commit 10cfd3a into v3 Jul 28, 2022
@jmillan
jmillan deleted the issue_882 branch July 28, 2022 13:50
@nazar-pc

nazar-pc commented Jul 28, 2022

Copy link
Copy Markdown
Collaborator

Can you bump mediasoup-sys patch version so I can publish Rust release too?

@jmillan

jmillan commented Jul 28, 2022

Copy link
Copy Markdown
Member Author

Can you bump mediasoup-sys patch version so I can publish Rust release too?

It's only about the version field in Cargo.toml, right?

@nazar-pc

Copy link
Copy Markdown
Collaborator

Yes, just patch version in worker/Cargo.toml

@ibc ibc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in CHANGELOG

@jmillan

jmillan commented Aug 1, 2022

Copy link
Copy Markdown
Member Author

You are very right, I missed that and I already released..

@jmillan

jmillan commented Aug 1, 2022

Copy link
Copy Markdown
Member Author

Done

piranna pushed a commit to dyte-in/mediasoup that referenced this pull request Feb 9, 2023
RtpStreamSend: Do not store too old RTP packets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Crash at assertion 'StorageItemBuffer contains more than 65535 entries'

3 participants