Transport: remove duplicate call to method - #931
Merged
Merged
Conversation
ibc
approved these changes
Oct 25, 2022
We were calling twice Producer->GetRtcp() and Consumer->GetRtcp(). Those calls were not having any effect because the above methods just return if they are called before than expected, so the second call had no effect.
Member
|
Conflicts |
jmillan
force-pushed
the
transport-sendrtcp-fix
branch
from
October 26, 2022 16:45
3da8356 to
42c2663
Compare
Member
Author
|
Fixed, I've force pushed this branch. |
ibc
approved these changes
Oct 26, 2022
|
Would the be the culprit to sometimes having delayed frames discussed in forums? |
Member
|
As the description of the PR says:
|
piranna
pushed a commit
to dyte-in/mediasoup
that referenced
this pull request
Feb 9, 2023
* Transport: remove duplicate call to method We were calling twice Producer->GetRtcp() and Consumer->GetRtcp(). Those calls were not having any effect because the above methods just return if they are called before than expected, so the second call had no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were calling twice Producer->GetRtcp() and Consumer->GetRtcp().
Those calls were not having any effect because the above methods just return if they are called before than expected, so the second call had no effect.