RtpRetransmissionBuffer: consider the case of packet with newest timestamp but "old" seq number - #1039
Merged
ibc merged 4 commits intoMar 29, 2023
Conversation
…stamp but "old" seq number Fixes #1037 ### Details: - We must consider the case in which, due for example to huge packet loss, received packet has higher timestamp than the newest packet in the buffer and, if so, use it to clear too old packets rather than the newest packet in the buffer. - Bonus track: restore buffer size to 2500 since increasing it didn't indeed help (it shouldn't help as proven).
jmillan
approved these changes
Mar 29, 2023
Member
Author
|
Amazing that CI didn't happen in this PR. Merging anyway. |
ibc
deleted the
rtpretransmissionbuffer-handle-newest-timestamp-with-old-seq
branch
March 29, 2023 16:31
Collaborator
|
GitHub Actions is having issues today: https://status.github.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Details: