Renamed WebRtcTransport webRtcServerClosed() to listenServerClosed() - #1141
Merged
Merged
Conversation
Member
|
And here a new added test that indeed fails in v3 branch and will pass once this PR is merged: |
Member
|
@nazar-pc I am not brave enough to know how this is done in Rust, I couldn't find any similar code so the bug probably doesn't happen in Rust. |
Collaborator
|
Cleanups are done in |
Contributor
Author
Glad you liked this PR :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found a typo where the
WebRtcTransport.webRtcServerClosed()was never called. Instead, theTransport.listenServerClosed()method is being directly called by WebRtcServer, so the clean-ups done atwebRtcServerClosed()are never done. SincelistenServerCloseevent is at Transport level with the idea maybe of have other listener servers in the future (raw TCP? RTP?), I've renamedwebRtcServerClosed()to the more generic onelistenServerClosed(), calling to the parent class.