Fix KSVC bitrate in IncreaseLayer - #1535
Merged
Merged
Conversation
ibc
reviewed
May 24, 2025
ibc
left a comment
Member
There was a problem hiding this comment.
Seems like a good catch but let me properly review this on next week.
jmillan
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the K-SVC configuration, when we calculate the amount of bitrate required to increase the spatial layer from S1 to S2, we need to subtract the bitrate of the current used layer (#1036). In the current code instead we use
GetBitratethat outputs the total bitrate used by the current plus the lower layer (S0+S1). The correct getter should be insteadGetSpatialLayerBitratethat gets the total bitrate of the current spatial layer.