Skip to content

Worker: Add Utils::Number class and fix issue 659 - #1574

Merged
ibc merged 10 commits into
v3from
worker-add-utils-number
Jul 16, 2025
Merged

Worker: Add Utils::Number class and fix issue 659#1574
ibc merged 10 commits into
v3from
worker-add-utils-number

Conversation

@ibc

@ibc ibc commented Jul 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Details

  • Utils::Number exposes static methods to compare uintXX_t values.
  • Replace Utils::Time::IsTimeLowerThan() etc. with the new Utils::Number functions.
  • Fix SeqManager comparisons when using N bits.
  • Tons of tests added.

Bonus tracks

ibc added 3 commits July 16, 2025 01:19
@ibc
Worker: Add Utils::Number class
4ac407c 
## Details

- `Utils::Number` exposes static methods to compare `uintXX_t` values.
- Replace `Utils::Time::IsTimeLowerThan()` etc.
@ibc
done
2074642
@ibc
cosmetic
420307d
@ibc
ibc marked this pull request as ready for review July 15, 2025 23:27
@ibc ibc changed the title Worker: Add Utils::Number class Worker: Add Utils::Number class and fix issue 659 Jul 15, 2025
@ibc
ibc requested a review from jmillan July 15, 2025 23:49
@ibc ibc mentioned this pull request Jul 15, 2025
Closed
jmillan
jmillan reviewed Jul 16, 2025
View reviewed changes
Comment thread worker/include/Utils.hpp
@ibc

ibc commented Jul 16, 2025

Copy link
Copy Markdown
Member Author

@jmillan I've updated the desc with a new commit:

  • Make RTC::SeqManager use Utils::Number instead of having a duplicate implementation.

@ibc
ibc merged commit becdf5f into v3 Jul 16, 2025
@ibc
ibc deleted the worker-add-utils-number branch July 16, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmillan jmillan jmillan approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update rtpStream->maxPacketTs in a specific scenario

2 participants

@ibc @jmillan