Skip to content

feat(3d-tiles): add traversal observability and benchmark baselines - #4018

Merged
ibgreen merged 15 commits into
masterfrom
codex/3d-tiles-observability
Sep 16, 2026
Merged

ibgreen merged 15 commits into
masterfrom
codex/3d-tiles-observability

Conversation

@ibgreen

@ibgreen ibgreen commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Goals

  • Make 3D Tiles traversal decisions reproducible for conformance tests and performance investigations.
  • Expose request, cache, memory, and implicit-subtree diagnostics without coupling the loader runtime to a renderer.
  • Document benchmark dimensions and practical budgets for future Cesium-parity work.

Changes

  • Add public Tileset3DTraversalSnapshot and getTileset3DTraversalSnapshot to @loaders.gl/tiles.
  • Expose defensive requestedTiles and emptyTiles views on Tileset3D.
  • Capture sorted selected/requested/empty IDs, renderable counts, loading/failure/cache counters, resident bytes, and active SSE.
  • Include implicit-subtree request, cache-hit, pending, and materialization counters when supplied by Tiles3DSource.
  • Add a 3D Tiles observability and benchmark guide, with links from the module and Tileset3D API pages.
  • Add hermetic Vitest coverage for deterministic ordering, defensive snapshots, and source diagnostics.
  • Add a v5 What's New bullet.

Tracker and scope

Partially addresses #1245, R3 (observability and benchmarks). This tranche is additive and does not change traversal policy, styling, GPU upload, or renderer draw decisions. R2 styling/feature access remains dependent on the existing R1 contracts and metadata work.

Validation

CI will run lint, builds, Node/headless tests, coverage, and the website build.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T20:53:37.992528Z 5e33a84 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ibgreen ibgreen mentioned this pull request Sep 16, 2026
54 tasks

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e33a84242

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/tiles/src/tileset-3d/common/tileset-3d.ts
Comment thread modules/tiles/src/tileset-3d/common/tileset-observability.ts
@ibgreen
ibgreen merged commit f28b043 into master Sep 16, 2026
20 of 21 checks passed
@ibgreen
ibgreen deleted the codex/3d-tiles-observability branch September 16, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant