feat(3d-tiles): add renderer-neutral style and feature access - #4021
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77579f74e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Review follow-up pushed: per-content group indices are now retained on Tile3DContent and resolved via metadataContext.groups; batch-table helpers guard known out-of-range IDs; style maps use null prototypes; and all documentation line breaks are real Markdown newlines. Added coverage for group selection and stale feature IDs. |
Goals
Advance the R2 styling and feature-access tranche for #1245 with renderer-neutral, typed property inputs while keeping styling evaluation and GPU policy outside loaders.gl.
Changes
Tile3DStyleInputsnapshots with deterministic tileset → group → tile → content → batch-table precedence.getTile3DStylePropertyandgetTile3DBatchTablePropertieshelpers; hierarchy-aware batch-table access remains delegated to the existing Cesium-derived implementation.getStructuralMetadataPropertyas a named-value wrapper over decoded property-table rows, preserving defaults, noData handling, and typed-array values.Scope
This is the loader-side foundation for R2. Full styling expression evaluation, feature picking/coloring policy, and GPU upload remain renderer-owned and are intentionally deferred to follow-up work.
Related: #1245