Skip to content

feat(ui): navigate trace steps with keyboard and remove indirect editor focus - #11005

Merged
sheremet-va merged 5 commits into
feat/editor-location-highlightfrom
feat/trace-step-navigation
Aug 19, 2026
Merged

sheremet-va merged 5 commits into
feat/editor-location-highlightfrom
feat/trace-step-navigation

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Recreated in the upstream repository by OpenCode (gpt-5.6-sol) on behalf of @hi-ogawa to test stacked PR behavior. This automated recreation has not been human-reviewed.\n> Original PR: #10986

Description

Trace steps currently require repeated clicks of each steps to go through and this can be cumbersome for quick skim.

This PR adds standard keyboard arrow/home/end navigation so it allows going up and down easily.

One fundamental editor behavior change is required for this, which is now "open editor" actions won't automatically move the browser focus to editor cursor at all. This behavior seems natural since if it's static report view, then moving the cursor there is meaningless, and even if it's editable watch UI, I don't think people would immediately start typing after such indirect cursor focus jump where you don't even know which column it jumped to.

📸 Demo

Demo from merge reports https://github.com/vitest-dev/vitest/actions/runs/32121156949/job/95663338646

Screen.Recording.2026-08-18.at.18.46.14.mov

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa and others added 5 commits August 18, 2026 17:07
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
@github-actions github-actions Bot added the maybe automated User is likely an AI agent, or the content was generated by an AI assistant without user control label Aug 19, 2026
@github-actions

Copy link
Copy Markdown

Hello @hi-ogawa. Your PR has been labeled maybe automated because it appears to have been fully generated by AI with no human involvement.

To keep your PR open, please follow these steps:

  • Confirm that you are a real human. If you are an automated agent, disclose that
  • Make sure you've read, reviewed and stand behind its content
  • Make sure you've read the full issue along with all of its comments, as well as any linked issues and their comments
  • Make sure it follows our contribution guidelines and uses the correct GitHub template
  • Disclose any AI tools you used (e.g. Claude, Copilot, Codex)

Please, do not generate or format the response with AI. If you do not speak English, reply in your native language or use translation software like Google Translate or Deepl. If the response is generated, the PR will be closed automatically.

These measures help us reduce maintenance burden and keep the team's work efficient. See our AI contributions policy for more context.

@hi-ogawa
hi-ogawa changed the base branch from main to feat/editor-location-highlight August 19, 2026 06:08
@sheremet-va sheremet-va removed the maybe automated User is likely an AI agent, or the content was generated by an AI assistant without user control label Aug 19, 2026
@sheremet-va
sheremet-va merged commit 6816f3b into main Aug 19, 2026
52 of 54 checks passed
@sheremet-va
sheremet-va deleted the feat/trace-step-navigation branch August 19, 2026 06:51
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support keyboard navigation between trace view step selection

2 participants