Skip to content

desktop: add official app icons and draggable shortcuts - #210

Open
medvednikov wants to merge 1 commit into
masterfrom
desktop-icons-shortcut-dnd
Open

desktop: add official app icons and draggable shortcuts#210
medvednikov wants to merge 1 commit into
masterfrom
desktop-icons-shortcut-dnd

Conversation

@medvednikov

@medvednikov medvednikov commented Sep 17, 2026

Copy link
Copy Markdown
Member

Summary

  • use official high-resolution Firefox, Chromium, Blender, GIMP, and LibreOffice application artwork instead of generic desktop glyphs
  • prefer icons already shipped by the assembled application packages and keep pinned official upstream fallbacks for reproducible/offline builds
  • convert icons at image-build time to a compact 256x256 RGBA format and sample them at the physical framebuffer resolution for crisp HiDPI rendering
  • launch desktop application shortcuts on left-button release instead of button press
  • turn shortcut movement past a small threshold into drag/reorder instead of launching
  • persist the desktop shortcut order by stable application process name in /root/.vinix-shortcut-order

Testing

  • added regression coverage for release-only shortcut launching, drag ordering, stable-name persistence, and icon-file loading
  • staged a dedicated desktop utility workflow against the final source snapshot before squashing; GitHub Actions had not assigned a runner while preparing this PR
  • the deliverable branch is one commit and does not contain the temporary workflow file

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

medvednikov
medvednikov commented Sep 20, 2026
View reviewed changes

@medvednikov medvednikov left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed f63a71b38d277e327466d1cf88dc2dcf82b99170. No actionable code regression identified in this change.

Traced shortcut press/move/release handling, drag cancellation of launch, normalization of persisted application identities, and startup loading. Checked the bounded VAI loader, physical-resolution sampling indices, missing-asset glyph fallback, and the Python writer's matching header/pixel layout. The new rendering path uses the same application identity after reordering rather than treating the desktop slot as an application index.

Validation: source/diff review of gesture state, persistence, loader/render integration, build staging, Python conversion, and the added utility-test cases. I did not execute the V desktop tests, launch the compositor, validate live pointer/HiDPI behavior, or inspect the binary artwork visually. No full desktop/image build was run. CI results were not considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@medvednikov