Repository navigation
Isolate Hugging Face dataset cache - #13
Open
GroveMinting wants to merge 1 commit into
Open
GroveMinting wants to merge 1 commit into
GroveMinting wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12.
What
--keep-cachefetch a process-owned temporary datasets cache./tmp.load_dataset(cache_dir=...).os._exit(0)path.--keep-cacheon the normal shared Hugging Face cache without overriding it.Why
The previous default recursively deleted
~/.cache/huggingface/datasets, which may contain unrelated datasets belonging to other projects. Mini-AGI should only remove cache files it created and owns.Verification
Seven tests pass. They cover:
--keep-cacheusing the library default;Also verified with
compileallandgit diff --check. The patch is independent of open PRs #7, #9, and #11.