Add "validate share data" algorithm - #185
Merged
Merged
Conversation
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Member
Author
|
@ericwilligers, @mgiuca, I think this is still useful to merge as a basis on which to build the things we discussed during the call. It's mostly just a refactor based on @inexorabletash suggestions. |
saschanaz
reviewed
Aug 14, 2021
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Member
Author
Member
|
Okay, thanks for web-platform-tests/wpt#30046. |
saschanaz
approved these changes
Aug 17, 2021
Member
Author
No problem. Do you want to review those too by chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps the good parts we derived from "canShare()".
For normative changes, the following tasks have been completed:
Implementation commitment:
Preview | Diff