Repository navigation
Define sharable scheme + check - #244
Merged
Merged
Conversation
marcoscaceres
commented
Jul 1, 2022
| of the document (e.g., "blob:"), return false. | ||
| </p> | ||
| <aside class="issue" data-number="178"></aside> | ||
| <li>If the |url|'s [=URL/scheme=] is a [=local scheme=], or |
Member
Author
There was a problem hiding this comment.
I know this check is kinda redundant, because they are not in the the "sharable scheme" list, but I wanted to be explicit in banning them.
marcoscaceres
commented
Jul 1, 2022
ewilligers
approved these changes
Jul 1, 2022
ewilligers
approved these changes
Jul 7, 2022
Member
Author
|
thanks for checking/approving it @ericwilligers. I'm adding a few WPTests. |
Member
Author
|
Actually, turned out we have tests already. https://github.com/web-platform-tests/wpt/blob/master/web-share/share-url-invalid.https.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178
For normative changes, the following tasks have been completed:
Implementation commitment:
Preview | Diff