Skip to content

Fix setConfiguration default value handling to match implementations. - #2691

Merged
jan-ivar merged 2 commits into
w3c:mainfrom
jan-ivar:configdefaults
Dec 2, 2021
Merged

jan-ivar merged 2 commits into
w3c:mainfrom
jan-ivar:configdefaults

Conversation

@jan-ivar

@jan-ivar jan-ivar commented Oct 22, 2021 •

Copy link
Copy Markdown
Member

Fixes #2690.


Preview | Diff

@jan-ivar jan-ivar self-assigned this Oct 22, 2021
@jan-ivar

Copy link
Copy Markdown
Member Author

For review I recommend split view with whitespace hidden.

@jan-ivar
jan-ivar merged commit 8a36da1 into w3c:main Dec 2, 2021
@jan-ivar
jan-ivar deleted the configdefaults branch December 2, 2021 00:14
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2023
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2023
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 24, 2023
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 24, 2023
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 30, 2023
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166

UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 30, 2023
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166

UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 30, 2023
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166

UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pc.setConfiguration()'s default value handling doesn't match implementations

2 participants