setParameters(), replaceTrack(), & insertDTMF() reject after stop(). - #2829
Merged
Conversation
Member
Author
|
WPT already checks for this, so only a spec-text update is needed to match. |
Contributor
|
This aligns with reasonable behavior (reject when "stop" has been called) and implementations. Seems to be a reasonable thing to merge. |
dontcallmedom
force-pushed
the
rejectstopping
branch
from
March 6, 2023 16:58
942e7a1 to
9e90e01
Compare
jan-ivar
commented
Mar 23, 2023
jan-ivar
commented
Mar 23, 2023
henbos
approved these changes
Mar 23, 2023
jan-ivar
commented
Mar 23, 2023
Orphis
approved these changes
Mar 23, 2023
|
This issue had an associated resolution in the minutes of WebRTC March 2023 meeting – 21 March 2023 (Issue #2820 / PR #2829 setParameters/insertDtmf/replaceTrack should reject on [[Stopping]] as well as [[Stopped]]?):
|
jan-ivar
commented
Apr 3, 2023
change id from 31 to 32
|
This issue was mentioned in WEBRTCWG-2023-02-21 (Page 29) |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2820.
Preview | Diff