Skip to content

Prevent GC of non-closed RTCDataChannels #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alvestrand merged 5 commits into from
Nov 2, 2023
Merged

Prevent GC of non-closed RTCDataChannels #2902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
294a253
Prevent GC of non-closed RTCDataChannels
jan-ivar Oct 6, 2023
1dc10ff
Missing connection ref
jan-ivar Oct 6, 2023
00262c1
fix indent
jan-ivar Oct 6, 2023
46363fd
Mark amendment as correction rather than addition
dontcallmedom Oct 12, 2023
0c99003
Make sure to add/remove datachannels in all the places.
jan-ivar Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions amendments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,5 +520,14 @@
"status": "candidate",
"id": 36
}
],
"closing-procedure": [
{
"description": "Prevent GC of non-closed RTCDataChannels",
Comment thread
jan-ivar marked this conversation as resolved.
"pr": 2902,
"type": "correction",
"status": "candidate",
"id": 38
}
]
}
38 changes: 37 additions & 1 deletion webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,6 +1312,13 @@ <h4>
</p>
</li>
<li>
<p>
Let <var>connection</var> have a
<dfn data-dfn-for="RTCPeerConnection">[[\DataChannels]]</dfn> internal slot, initialized to
an empty [=ordered set=].
Comment thread
jan-ivar marked this conversation as resolved.
</p>
</li>
<li>
<p>
Let <var>connection</var> have an <dfn data-dfn-for="RTCPeerConnection">[[\Operations]]</dfn>
internal slot, representing an [= operations chain =],
Expand Down Expand Up @@ -13326,6 +13333,12 @@ <h2>
negotiation-needed flag =] for <var>connection</var>.
</p>
</li>
<li>
<p>
[=list/Append=] <var>channel</var> to
<var>connection</var>.{{RTCPeerConnection/[[DataChannels]]}}.
Comment thread
jan-ivar marked this conversation as resolved.
Comment thread
jan-ivar marked this conversation as resolved.
</p>
</li>
<li>
<p>
Return <var>channel</var> and continue the following
Expand Down Expand Up @@ -13894,6 +13907,12 @@ <h4>
<code>false</code>.
</p>
</li>
<li>
<p>
[=list/Append=] <var>channel</var> to
<var>connection</var>.{{RTCPeerConnection/[[DataChannels]]}}.
</p>
</li>
<li data-tests="RTCPeerConnection-ondatachannel.html">
<p>
Set <var>channel</var>.{{RTCDataChannel/[[ReadyState]]}} to
Expand Down Expand Up @@ -13922,7 +13941,7 @@ <h4>
</li>
</ol>
</section>
<section>
<section id="closing-procedure">
<h4>
Closing procedure
</h4>
Expand All @@ -13940,6 +13959,17 @@ <h4>
[= underlying data transport =] was closed.
</p>
</li>
<li class="no-test-needed">
<p>
Let <var>connection</var> be the {{RTCPeerConnection}} object
associated with <var>channel</var>.
</p>
</li>
<li>
<p>
[=list/Remove=] <var>channel</var> from <var>connection</var>.{{RTCPeerConnection/[[DataChannels]]}}.
</p>
</li>
<li>
<p>
Unless the procedure was initiated by
Expand Down Expand Up @@ -14011,6 +14041,12 @@ <h4>
{{RTCDataChannelState/"closed"}}.
</p>
</li>
<li>
<p>
[=list/Remove=] <var>channel</var> from <var>connection</var>.{{RTCPeerConnection/[[DataChannels]]}}
if it is still there.
</p>
</li>
<li>
<p>
If the [= underlying data transport | transport =] was closed
Expand Down