Skip to content

Update aria sort value descriptions to include "row" fixes #1614 #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2022
Merged

Update aria sort value descriptions to include "row" fixes #1614 #1616

merged 2 commits into from
Jan 13, 2022

Conversation

@jorycunningham
Copy link
Contributor

@jorycunningham jorycunningham commented Sep 16, 2021 •
edited by pr-preview bot
Loading

Address #1614 by adding "or row" to descriptions of aria-sort values so that they now say "column or row"

Preview | Diff

jnurthen
jnurthen reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the text at https://w3c.github.io/aria-practices/#gridAndTableProperties_sort (in particular I really dislike the plural form of data and have no idea why this was changed from items in APG) but it would be good to be consistent. Why not just drop the column or row part.

@scottaohara
Copy link
Member

scottaohara commented Sep 17, 2021

i'd personally rather APG be updated. I'm also not a fan of the wording over there.

@jorycunningham
Copy link
Contributor Author

jorycunningham commented Sep 23, 2021

@scottaohara @jnurthen Updated this based on our conversation in ARIA WG today

@scottaohara
Copy link
Member

scottaohara commented Sep 23, 2021

now we can update apg to match this ;)

lgmt

@pkra pkra added this to the ARIA 1.3 milestone Jan 12, 2022
@pkra pkra merged commit b710565 into main Jan 13, 2022
@pkra pkra deleted the aria-sort-values branch January 13, 2022 07:36
github-actions bot added a commit that referenced this pull request Jan 13, 2022
@jorycunningham @github-actions
Update aria sort value descriptions to include "row" fixes #1614 (#1616)
97f1a49 
SHA: b710565
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkra pkra pkra approved these changes

@jnurthen jnurthen jnurthen approved these changes

@scottaohara scottaohara scottaohara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023

Development

Successfully merging this pull request may close these issues.

5 participants

@jorycunningham @scottaohara @pkra @jnurthen