Skip to content

update figure role #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 1, 2022
Merged

update figure role #1705

merged 5 commits into from
Sep 1, 2022

Conversation

@scottaohara
Copy link
Member

@scottaohara scottaohara commented Mar 12, 2022 •
edited by pr-preview bot
Loading

This PR requires #1703 be merged.

Preview | Diff

@scottaohara
update figure role
5a14d4d 
This PR requires #1703 be merged.
chlane
chlane approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@chlane chlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that aria-label and aria-labelledby can be used to label a figure element

charmarkk
charmarkk approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@charmarkk charmarkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, and editorial looks good.

smhigley
smhigley reviewed Apr 1, 2022
View reviewed changes
scottaohara
scottaohara commented Apr 1, 2022
View reviewed changes
@scottaohara scottaohara requested a review from smhigley April 14, 2022 17:15
MelSumner
MelSumner approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Approved the related PR as well. 👍

@pkra pkra added this to the ARIA 1.3 milestone Apr 29, 2022
@pkra
Copy link
Member

pkra commented Apr 29, 2022

@smhigley is this one ok by you now?

@pkra
Copy link
Member

pkra commented Sep 1, 2022

@scottaohara would you be able to resolve the merge conflicts?

@scottaohara
Copy link
Member Author

scottaohara commented Sep 1, 2022

@pkra done

@pkra pkra merged commit c625cb7 into main Sep 1, 2022
@pkra pkra deleted the scottaohara-figure-definition-updates branch September 1, 2022 19:21
pkra pushed a commit that referenced this pull request Sep 2, 2022
@scottaohara @pkra
update figure role (#1705)
8220ef3 
* update figure role
  This PR requires #1703 be merged.
* Update index.html
* revisions per sarah's review
* further updates to figure def
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@scottaohara @jnurthen
update figure role (#1705)
6a8de39 
* update figure role
  This PR requires #1703 be merged.
* Update index.html
* revisions per sarah's review
* further updates to figure def
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smhigley smhigley smhigley approved these changes

@MelSumner MelSumner MelSumner approved these changes

@charmarkk charmarkk charmarkk approved these changes

@chlane chlane chlane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023

Development

Successfully merging this pull request may close these issues.

7 participants

@scottaohara @pkra @smhigley @MelSumner @charmarkk @chlane