Editorial: Fix description for aria-keyshortcuts #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
double-quote ... 34, single-quote ... 39 I also removed the Shift modifier, as it's not a part of the escaping sequence and was confusing (you can type double-quote with shift+single-quote in US keyboard layout). The combination of modifier keys and escaping sequence exists in the "Examples of valid keyboard shortcuts include" list.
|
jnurthen marked as non substantive for IPR from ash-nazg. |
|
I think the simplification of the example is useful especially for those unfamiliar with a US keyboard. |
jnurthen
approved these changes
May 10, 2022
pkra
approved these changes
May 11, 2022
spectranaut
approved these changes
Jul 8, 2022
pkra
pushed a commit
that referenced
this pull request
Jul 14, 2022
Fixed the character name and removed the (probably unnecessary) modifier key from an example for `aria-keyshortcuts` - `'` ... `'`, `"` ... `"` I also removed the Shift modifier, as it's not a part of the escaping sequence and was confusing (you can type double-quote with shift+single-quote in US keyboard layout). The combination of modifier keys and escaping sequence exists in the "Examples of valid keyboard shortcuts include" list.
jnurthen
pushed a commit
that referenced
this pull request
Oct 10, 2023
Fixed the character name and removed the (probably unnecessary) modifier key from an example for `aria-keyshortcuts` - `'` ... `'`, `"` ... `"` I also removed the Shift modifier, as it's not a part of the escaping sequence and was confusing (you can type double-quote with shift+single-quote in US keyboard layout). The combination of modifier keys and escaping sequence exists in the "Examples of valid keyboard shortcuts include" list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'...',"..."Fixed the character name and removed the (probably unnecessary) modifier key from an example for
aria-keyshortcuts.Although I'm not sure whether the line was a typo or intentional (as you can type
"by hitting Shift + ' in US layout), I think at least it's confusing for readers, especially those who are not familiar with US keyboard layout.Please close if I'm misunderstanding or the code point (
') needs to be changed instead.Preview | Diff