Align ARIAMixin with changes in HTML - #1876
Conversation
This does not address most of the issues described in w3c#1110, but does provide a better base for ElementInternals support and tackling the issues in w3c#1110. Corresponding HTML change: whatwg/html#8496.
|
Converting to draft until upstream PR is resolved. |
domenic
left a comment
There was a problem hiding this comment.
LGTM, I guess this did dramatically simplify things.
|
I think it might have to get more complicated as we address the remaining issues around |
Other changes: * Remove reflection of unrestricted double as it is buggy and unused. * The DOMString getter steps did not account for a missing attribute. * The native accessibility semantics map was renamed to the internal content attribute map as it's now a more general reflection concept. Corresponding ARIA PR: w3c/aria#1876. Fixes #8442. Follow-up: * w3c/core-aam#152 * w3c/aria#1110 * #3238 * #8544 * #8545 * #8926 * #8927 * #8928 * #8930
|
Can anyone work on merging this? I got very confused implementing the current spec in jsdom. |
keithamus
left a comment
There was a problem hiding this comment.
This looks like a straightforward and worthwhile change to me, once the above comment is resolved.
cookiecrook
left a comment
There was a problem hiding this comment.
Approve with included edits.
spectranaut
left a comment
There was a problem hiding this comment.
Applied edits on @cookiecrook's edits.
|
This looks ready to merge per today's meeting (https://www.w3.org/2024/02/15-aria-minutes#t08) - I'll resolve merge conflicts and land. |
SHA: d2c9883 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This does not address most of the issues described in #1110, but does provide a better base for ElementInternals support and tackling the issues in #1110.
Corresponding HTML change: whatwg/html#8496.
This is meant to be editorial when combined with the HTML PR landing around the same time, leaving existing spec-UB as spec-UB. Please do not merge this before the HTML PR is merged.
cc @domenic
Preview | Diff