Skip to content

Update dialog definition - #2054

Merged
jnurthen merged 3 commits into
mainfrom
so-dialog
Dec 11, 2024
Merged

Update dialog definition#2054
jnurthen merged 3 commits into
mainfrom
so-dialog

Conversation

@scottaohara

@scottaohara scottaohara commented Oct 2, 2023

Copy link
Copy Markdown
Member

Closes: #1195 adds content pertaining to aria-describedby/description and aria-modal (with linking to APG).

Closes: #1739 adds AT SHOULD to address the treatment of dialog descriptions. This could probably be worded better. Suggestions welcome.


Preview | Diff

Closes: #1195 adds content pertaining to aria-describedby/description and aria-modal (with linking to APG).

Closes: #1739 adds AT SHOULD to address the treatment of dialog descriptions. This could probably be worded better.  Suggestions welcome.
@jnurthen
jnurthen requested review from coryj627 and mcking65 October 5, 2023 17:24
@jnurthen jnurthen changed the title Update dialog defnition Update dialog definition Oct 5, 2023
@jnurthen
jnurthen self-requested a review October 5, 2023 17:25
Comment thread index.html Outdated
@mcking65

Copy link
Copy Markdown
Contributor

@scottaohara @jnurthen

I think we should have some discussion of the use cases and justification for aria-description on a dialog. I'm almost inclined to say that it should not be allowed. I think it deserves discussion though.

@mcking65

Copy link
Copy Markdown
Contributor

I agree with Carolyn's questioning of the wording around "managing focus". Managing focus is relevant for composites and does not equate to constraining the tab ring. I'm happy to propose some alternative wording.

@scottaohara How would you prefer I propose wording? It might be kind of difficult to do it with the suggestion feature? Are you OK with me pushing commits to this branch? Or, would you prefer I branch from this and use this branch as a base for a PR?

@scottaohara

Copy link
Copy Markdown
Member Author

@mcking65 yah, i think it does make sense to change the wording on 'managing focus'. happy for you to make commits to the branch. that'll be easy enough for me to review the diff.

@mcking65 just trying to get this PR wrapped up, but I added a note about aria-description and made a wording changes to 'manage focus' (though that is existing text, and not added by this PR - so kinda out of scope, but i think an easy change worth making.
@scottaohara

Copy link
Copy Markdown
Member Author

@mcking65 @jnurthen - i made updates based on matt's prior comments. pinging for review/re-review

@jnurthen

Copy link
Copy Markdown
Member

@mcking65 waiting for your review

@pkra pkra added the spec:aria label Jun 14, 2024
@scottaohara

Copy link
Copy Markdown
Member Author

@jnurthen @mcking65 it's been almost a year since the last edits I had made per Matt's prior review. Can this be merged if there are no other comments?

Comment thread index.html Outdated
@netlify

netlify Bot commented Dec 11, 2024

Copy link
Copy Markdown

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit c66033a
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/6759c7bfa3021d0009dfe61b
😎 Deploy Preview https://deploy-preview-2054--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jnurthen
jnurthen merged commit d5e6cf3 into main Dec 11, 2024
github-actions Bot added a commit that referenced this pull request Dec 11, 2024
SHA: d5e6cf3
Reason: push, by jnurthen

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment thread index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should the ARIA spec suggest setting a description on dialogs? Consider discussing aria-describedby and aria-modal in dialog prose

6 participants