Repository navigation
Remove group as allowed child of tree - #2094
Merged
Merged
Conversation
This was referenced Dec 17, 2023
adampage
approved these changes
Jan 9, 2024
rahimabdi
approved these changes
Jan 11, 2024
giacomo-petri
approved these changes
Aug 19, 2024
spectranaut
self-requested a review
September 5, 2024 17:49
Contributor
|
Since I approved the PR without adding any notes (and changes seem great based on the rationale of #2315), I'm assuming I mistakenly applied the agenda label to the wrong GitHub PR. Now, it would be interesting to figure out where I missed applying the agenda label... 🥲 |
smhigley
approved these changes
Sep 11, 2024
Contributor
|
Discussed in today's meeting: https://www.w3.org/2025/02/13-aria-minutes.html#6a80 |
Contributor
|
Opened issue in ACT repo as requested: act-rules/act-rules.github.io#2309 |
6 tasks
YusukeHirao
added a commit
to markuplint/markuplint
that referenced
this pull request
Apr 14, 2025
…IA spec change Aligns with W3C ARIA specification change (w3c/aria#2094). The 'tree' role no longer requires 'group > treeitem' as direct children according to the ARIA specification update. Direct children of a 'tree' must be 'treeitem'. See: w3c/aria#2094
YusukeHirao
added a commit
to markuplint/markuplint
that referenced
this pull request
Apr 14, 2025
…IA spec change Aligns with W3C ARIA specification change (w3c/aria#2094). The 'tree' role no longer requires 'group > treeitem' as direct children according to the ARIA specification update. Direct children of a 'tree' must be 'treeitem'. See: w3c/aria#2094
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2014
Removes group as an allowed accessibility child of tree to fix inconsistency with definition of treeitem. Direct children of tree can only be parent nodes or end nodes. Leaf nodes must be a child of a group that is a child of a parent node treitem. Even in a virtualized tree, if the elements that represent the ancestry of rendered nodes were not present in the DOM, the tree would be inoperable.
PR tracking
Check these when the relevant issue or PR has been made, OR after you have confirmed the
related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the
Process Document or
Test Overview for more information.
Implementation tracking
Preview | Diff