Skip to content

[web-animations-2] Web IDL syntax error #11624

Closed

Description

@autokagami

🤖 This is an automatic issue report for Web IDL syntax error. 🤖

webidl2.js says:

Syntax error at line 6 in web-animations-2,15, since `interface AnimationTrigger`:
 CSSKeywordValue or DOMString) rangeStart = "normal";
                                          ^

Error: Unterminated attribute, expected ;

Please file an issue at https://github.com/saschanaz/webidl-updater/issues/new if you think this is invalid or should be enhanced.

Activity

  1. tidoust commented on Jan 31, 2025

    @tidoust
    Member

    I suspect the intent of the change was to set default values for the attributes. Default values are not allowed in interface attributes in Web IDL, only for dictionary members.

  2. tidoust commented on Jan 31, 2025

    @tidoust
    Member

    Also note that, even without the default value, the definition of the attribute remains invalid for the same reason as that noted in
    #9355 (comment): "dictionaries aren't allowed as attribute types"

  3. ydaniv commented on Jan 31, 2025

    @ydaniv
    Member

    Thanks! I'll push a fix

  4. ydaniv commented on Jan 31, 2025

    @ydaniv
    Member

    I think this should do as a fix: #11630

  5. tidoust commented on Feb 4, 2025

    @tidoust
    Member

    Oh, failed to notice, but another IDL hiccup will appear once you fix the other ones: a nullable union cannot include a dictionary type, see https://webidl.spec.whatwg.org/#idl-nullable-type

    That will happen because dictionary members in AnimationTriggerOptions are defined with a ?.

  6. ydaniv commented on Feb 8, 2025

    @ydaniv
    Member

    Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions