Skip to content

[css-display] Define default display types in the right section #2658

Closed

Description

@Loirooriol

It's not a big deal, but I think it's a bit confusing that the default inner display type value is defined in Outer Display Roles for Flow Layout, and the default outer display type value is defined in the Inner Display Layout Models. I think the opposite would make more sense.

Activity

  1. fantasai commented on May 22, 2018

    @fantasai
    Collaborator

    Oy. There's a good argument for either way: the argument for leaving it as-is, is that in the section defining a particular set of keywords, it's more clearly explained that keyword means in isolation. Probably if the default was simple, I'd lean towards accepting your change... but the "default" outer display type used when an outer display type isn't specified is actually dependent on which inner display type was specified. (It usually implies 'block', but 'ruby' implies 'inline'.)

    Also, outer display types are only implied if an inner display type is specified and vice versa: if a layout-internal display type is specified, there is no default outer display type or inner display type, as the concept doesn't apply. Ditto 'none' and 'contents'.

    ... So altogether, I'm leaning towards rejecting this editorial change. I'll check with @tabatkins, though.

  2. tabatkins commented on May 30, 2018

    @tabatkins
    Member

    Hmmm, I think I agree with @fantasai. While it's definitely true that we usually define what an omitted production means in the section that defines the production, here I think it's clearer to define what a keyword by itself means (and thus, what the other keyword will default to). The two productions are intricately linked, not largely independent as most productions are, so defining them in isolation ("block means X, inline means Y, omitted means either block or inline, depending on this other thing") isn't as fruitful.

  3. Loirooriol commented on May 30, 2018

    @Loirooriol
    ContributorAuthor

    Your arguments are reasonable, I'm fine with no change.

  4. added
    Commenter SatisfiedCommenter has indicated satisfaction with the resolution / edits.
    on Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions