You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[css-grid] Simplifying the new syntaxt of the grid shorthand #438
The new syntax suggests the use of " [ auto-flow && dense? ]" instead of reusing the current syntax. The only different is that allows omitting the 'auto-flow' value, assuming 'row' in that case.
IIRC the reason Tab and I decided to use 'auto-flow' rather than the 'row'/'column' keywords was to make the shorthand a little more self-evident: just stating 'row' or 'column' in the appropriate place didn't make it as clear that the subsequent track-sizes were auto-flowed rather than part of the template. Since whether it was a row or column was already implied by the placement (it's implied whether you're doing auto-flow or template), we decided to use the 'auto-flow' part of the property name as a keyword here.
Ok, I really don't have an strong opinion, regarding the syntax, and I understand your point. My doubt was just whether we could simply the syntax, so we can do it the same at the implementation level.
I'll leave this open for a while, just in case somebody else wants to add something, but I'll proceed with the implementation of the new syntax as it's written now.
Activity
fantasai commentedon Sep 2, 2016
IIRC the reason Tab and I decided to use 'auto-flow' rather than the 'row'/'column' keywords was to make the shorthand a little more self-evident: just stating 'row' or 'column' in the appropriate place didn't make it as clear that the subsequent track-sizes were auto-flowed rather than part of the template. Since whether it was a row or column was already implied by the placement (it's implied whether you're doing auto-flow or template), we decided to use the 'auto-flow' part of the property name as a keyword here.
javifernandez commentedon Sep 7, 2016
Ok, I really don't have an strong opinion, regarding the syntax, and I understand your point. My doubt was just whether we could simply the syntax, so we can do it the same at the implementation level.
I'll leave this open for a while, just in case somebody else wants to add something, but I'll proceed with the implementation of the new syntax as it's written now.
fantasai commentedon Sep 13, 2016
Javier, does this logic work for you? Or do you have a further comment to consider?
javifernandez commentedon Sep 13, 2016
Yes, I'm fine with the decision.