Skip to content

Handling of invalid properties #1673

Closed

Description

@mattgarrish

For the property data type, we say Reading System concatenation of the base URL and value must result in a valid url string.

So what happens if it doesn't? Must Reading Systems ignore the value? Should they ignore it? Or do we not care?

Activity

  1. iherman commented on May 12, 2021

    @iherman
    Member

    My vote would be to ignore the value (and, possibly, issue a warning)

  2. added
    Agenda+Issues that should be discussed during the next working group call.
    on May 12, 2021
  3. bduga commented on May 13, 2021

    @bduga
    Collaborator

    Where is the current conformance language? I am somehow not seeing it.

  4. mattgarrish commented on May 13, 2021

    @mattgarrish
    MemberAuthor
  5. iherman commented on May 14, 2021

    @iherman
    Member

    The issue was discussed in a meeting on 2021-05-13

    List of resolutions:

    View the transcript

    7. Handling of invalid properties

    See github issue #1673.

    Matt Garrish: when I was making the URL spec change this came up
    … when property values expand, they are supposed to expand into valid URL string
    … assuming that if it is invalid, then RS should ignore property

    Brady Duga: there are also situations where RS is suppose to ignore in failure case

    Dave Cramer: right, this causes as little disruption to reading experience as possible
    … e.g. not doing something to alert the reader

    Proposed resolution: If a property is invalid, ignore it, close issue 1673 (Wendy Reid)

    Ben Schroeter: +1

    Shinya Takami (高見真也): +1

    Brady Duga: +1

    Matt Garrish: +1

    Dave Cramer: +1

    Matthew Chan: +1

    Fred Chasen: +1

    Toshiaki Koike: +1

    Wendy Reid: +1

    Resolution #3: If a property is invalid, ignore it, close issue 1673

  6. iherman commented on May 14, 2021

    @iherman
    Member

    @mattgarrish I did not know whether you want to change something on the spec related to this, so I did not close this issue yet.

  7. removed
    Agenda+Issues that should be discussed during the next working group call.
    on May 14, 2021
  8. mattgarrish commented on May 14, 2021

    @mattgarrish
    MemberAuthor

    Also will close automatically with #1650. I've added the statement to the updated section on expanding property data types (as linked in the above comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    EPUB33Issues fixed in the EPUB 3.3 revisionSpec-ReadingSystemsThe issue affects the EPUB Reading Systems 3.X Recommendation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions