Skip to content

Removing editor's notes - #1934

Merged
iherman merged 2 commits into
mainfrom
removing-editors-notes
Nov 23, 2021
Merged

iherman merged 2 commits into
mainfrom
removing-editors-notes

Conversation

@iherman

@iherman iherman commented Nov 23, 2021

Copy link
Copy Markdown
Member

Two editors' notes have been added in #1898. Those two notes have been turned into explicit issues (see #1932 and #1933), and this PR removes those two notes from the spec.

@dauwhe dauwhe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a close div that should be removed, too?

@mattgarrish mattgarrish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just what @dauwhe said, otherwise fine by me.

@iherman

iherman commented Nov 23, 2021

Copy link
Copy Markdown
Member Author

I think there's a close div that should be removed, too?

Oops.... Thanks!

@iherman
iherman merged commit 2834995 into main Nov 23, 2021
@mattgarrish
mattgarrish deleted the removing-editors-notes branch November 26, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants