Remove redundant processing requirement for hreflang attribute - #2343
Merged
Conversation
iherman
approved these changes
Jun 24, 2022
iherman
left a comment
Member
There was a problem hiding this comment.
You asked, in w3c/epub-tests#173 (comment)
I'll open a pull request with an additional reference to this paragraph, but I wonder if we can delete this bit of duplication completely?
I would be in favour of keeping it. It does not harm, it does not add any normative text, but may be helpful for RS implementers.
Member
|
I would think this could be merged, @mattgarrish. If you do, could you also close w3c/epub-tests#173 without merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in w3c/epub-tests#173, we have a redundant requirement on language processing for the
hreflangattribute.The internationalization section already defines that language and direction are obtained from resources, not information in the package document, and specifically calls out
hreflangas one case.This pull request just removes the redundant must for now, replacing it with a pointer to the overarching requirement, but I'm easily convinced we can drop the entire paragraph. It only seems to serve the purpose of reminding a developer of an existing requirement, but we don't repeat this for every element that has a language or direction property, so why here?
EPUB Reading Systems 3.3: