Skip to content

Media type registrations are normative - #2325

Merged
mattgarrish merged 3 commits into
mainfrom
media-type-normative
Jun 7, 2022
Merged

Media type registrations are normative#2325
mattgarrish merged 3 commits into
mainfrom
media-type-normative

Conversation

@iherman

@iherman iherman commented Jun 6, 2022 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Member

This is a PR for the branch behind #2297 in view of a CRS publication.

Fix #2313

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jun 7, 2022, 1:35 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL


😭  Sorry, there was an error generating the HTML. Please report this issue!
Specification: http://labs.w3.org/spec-generator/uploads/fttDRc?isPreview=true&publishDate=2022-06-07
ReSpec version: 32.1.8
File a bug: https://github.com/w3c/respec/
Error: Error: Evaluation failed: Timeout: document.respec.ready didn't resolve in 27664ms.
    at ExecutionContext._evaluateInternal (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:221:19)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async ExecutionContext.evaluate (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:110:16)
    at async generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:221:12)
    at async toHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:92:18)
    at async Object.generate [as respec] (file:///u/spec-generator/generators/respec.js:15:44)
    at async file:///u/spec-generator/server.js:247:48

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@iherman
iherman requested review from mattgarrish and wareid June 6, 2022 07:58
@mattgarrish

mattgarrish commented Jun 6, 2022

Copy link
Copy Markdown
Member

Note that the auto-close on #2313 won't work when you merge into a branch (it's not shown as linked in the issues list). You'd need to mention it from #2297.

Do we want to close #2313 with this update, though, or leave it open until the IANA registration is closed?

@iherman

iherman commented Jun 6, 2022

Copy link
Copy Markdown
Member Author

Let us merge/close it. The IANA registration (more exactly, modification) is a different issue.

@iherman

iherman commented Jun 7, 2022

Copy link
Copy Markdown
Member Author

@mattgarrish should we change this PR so that it patches the 'main' branch rather than #2297? By doing so, we can merge #2297 at once (we have the green light of the WG as well as PlH's). Just to clean up the PR-s...

@mattgarrish
mattgarrish changed the base branch from editorial/issue-2265 to main June 7, 2022 13:31
@mattgarrish

mattgarrish commented Jun 7, 2022

Copy link
Copy Markdown
Member

I've switched it to integrate with main now. It's showing the commits for #2297, but after I merge that one I should be able to merge main back in here to clean it up.

@mattgarrish
mattgarrish merged commit 3e2c9a8 into main Jun 7, 2022
@mattgarrish
mattgarrish deleted the media-type-normative branch June 7, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattgarrish mattgarrish mattgarrish approved these changes
@wareid wareid Awaiting requested review from wareid

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should media type registration be normative?

2 participants

@iherman @mattgarrish