Repository navigation
Clarify that ocf processing files are not listed in the manifest - #2506
Merged
Merged
Conversation
mattgarrish
requested review from
dauwhe,
iherman,
rdeltour,
shiestyle and
wareid
December 16, 2022 13:34
Member
|
See also #2413, for reference. |
rdeltour
approved these changes
Dec 16, 2022
rdeltour
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I like that this removes a normative statement that cannot be checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As raised in w3c/epubcheck#1452, I don't know that we can ever perfectly clarify what publication resources are, but PR makes clear that the mimetype file and meta-inf files are not, so they are not listed in the manifest.
That should make the statement about the manifest only listing publication resources redundant, as the other cases are now explained (linked resources and the above files).
There will still be impossibilities for epubcheck to determine, like whether a publication resource without any reference to it is intentionally travelling in the container or was forgotten to be removed, but as noted in the epubcheck issue we can add usage messages to flag those.
Preview | Diff