feat: check the formal viewport meta tag syntax
#1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `HTM-047` is now reported for invalid `viewport` values - new `HTM-056` is reported when a `viewport` value has no `width` or `height` - new `HTM-057` is reported when a viewport width or height value is invalid (i.e. not a positive number or a well-known kewyword) Also: - the `isASCIIWhitespace` static utility method is extraced to a public `InfraUtil` class in a new `org.w3c.epubcheck.util.infra` package - the viewport parser is tested as a standalone class in its own feature file. However, for easier lookup, this file is however located in the `epub3/F-viewport-meta-tag` directory, as if it was a functional test. - several additional functional tests are added to the `epub3/08-layout` directory, for viewport metadata checks. Fixes #1214, fixes #1347
This was referenced Dec 2, 2022
mattgarrish
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTM-047is now reported for invalidviewportvaluesHTM-056is reported when aviewportvalue has nowidthorheightHTM-057is reported when a viewport width or height value is invalid (i.e. not a positive number or a well-known kewyword)Also:
isASCIIWhitespacestatic utility method is extraced to a publicInfraUtilclass in a neworg.w3c.epubcheck.util.infrapackageepub3/F-viewport-meta-tagdirectory, as if it was a functional test.epub3/08-layoutdirectory, for viewport metadata checks.Fixes #1214, fixes #1347
Note: this does not include the latest post-CR updates to the viewport requirements