Skip to content

Missing condition in section 3.3.8, first "f." #15

Closed

Description

@emuller-amazon

Section 3.3.8, first set of a., b., c., etc.

f. When the adjacent character is one of the closing brackets (cl-02), the ruby text may...
...
h. Also, when the adjacent character is one of the opening brackets (cl-01) before the ruby object, the ruby text may...

f. fails to say this is only when the bracket is after the ruby object h. does indicate this corresponding restriction (before the ruby object)

So, at the very least, insert "after the ruby object" after "(cl-02)" in f.

Even better, I think that f, g and h can be combined:

When the preceding character is an opening bracket, or when the following character is a closing bracket, a comma or a full stop, the ruby text may go over these adjacent characters, up to the full-width size of a ruby character. Note that the overhang must not go beyond those adjacent characters.

Activity

  1. himorin commented on May 13, 2019

    @himorin
    Contributor

    Toshi Kobayashi san updated text of f,g,h by combining into one.

  2. self-assigned this
    on Jun 11, 2019
  3. macnmm commented on Jun 11, 2019

    @macnmm
    Contributor

    @himorin I have some edits to make over the entire ruby section's English. Should we close this issue out first, or should I address the whole section as well as the few lines involved in this issue?

  4. himorin commented on Jun 17, 2019

    @himorin
    Contributor

    I'd want to have an issue for edits over the entire this section first, also I don't think closing this without fix is a good way.

  5. macnmm commented on Jun 17, 2019

    @macnmm
    Contributor

    OK I was able to separate out the fix for #10. However in re-wording the fix for #15, I changed "ruby letter" to "ruby character", and "go over" to "overhang". This introduced inconsistencies in all the places where the former phrases are used. So, I unified on the phrases I prefer. That is why the #15 change covers more areas. So, this time I can use the "letter" and "go over" phrasing in my smaller change and create an issue about "letter" and "go over" to clean up further in another PR...

  6. himorin commented on Jun 18, 2019

    @himorin
    Contributor

    initial target point fixed and merged, closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

jlreq-doc:errata[JLReq-doc] errata fix items for 2nd edition

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions