editorial: Adds localization members list - #1245
Open
diekus wants to merge 1 commit into
Open
Conversation
- Adds a list of members that are localisable in the definition of the `*_localized` members (name, short_name, description, icons, and the shortcut item's internal members). Makes clearer which are the members that are currently localizable.
Collaborator
|
Diego I'm not sure what's going on with your checkout, but the 'files changed' tab here shows quite a lot of changes. Maybe rebase or merge your fork and branch? |
Collaborator
|
I'm going to convert this to a draft, convert back after it is resolved. |
dmurph
marked this pull request as draft
August 17, 2026 18:08
Member
Author
|
changed the base to |
diekus
marked this pull request as ready for review
August 20, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1230
This change (choose at least one, delete ones that don't apply):
Implementation commitment (delete if not making normative changes):
Commit message:
Adds a list of localisable members in the
*_localizedmember section for clarity.💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Aug 20, 2026, 2:26 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build bikeshed/ReSpec specs
🔗 Related URL
Error output:
This seems to be an issue with the Spec Generator service. PR Preview doesn't manage this service and so has no control over it. If you've identified an issue with it, you can report the issue to the maintainers of Spec Generator directly. Please be courteous. Thank you!
If you don't have enough information above to solve the error by yourself or if the issue doesn't seem related to Spec Generator, you can file an issue with PR Preview.